[PWGDQ] Removing ROOT dictionaries#16838
Merged
Merged
Conversation
|
O2 linter results: ❌ 269 errors, |
aalkin
reviewed
Jun 26, 2026
| { | ||
| public: | ||
| AnalysisCompositeCut(bool useAND = kTRUE); | ||
| explicit AnalysisCompositeCut(bool useAND = kTRUE); |
Member
There was a problem hiding this comment.
If you use this class as a data member in an analysis task, the explicit constructor will probably break the decomposition that is used to parse the task's content.
Collaborator
Author
There was a problem hiding this comment.
Indeed ... I removed the explicit, thanks
Collaborator
|
Error while checking build/O2Physics/o2 for 590cbb9 at 2026-06-26 20:41: Full log here. |
Collaborator
|
Error while checking build/O2Physics/staging for 590cbb9 at 2026-06-26 20:43: Full log here. |
aalkin
reviewed
Jun 26, 2026
| //____________________________________________________________________________ | ||
| void AnalysisCut::PrintCuts() | ||
| { | ||
| cout << "**************** AnalysisCut::PrintCuts" << endl; |
Member
There was a problem hiding this comment.
Not really related to this PR, but since these classes are probably not used outside of O2Physics, it makes sense to use framework log facilities instead of iostream.
Collaborator
There was a problem hiding this comment.
As reported by the O2 linter...
iarsene
approved these changes
Jun 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@iarsene @aalkin @ktf as suggested in PR#16823